transfer of archives from the ezboard forum [closed]

Discussion about the Geocaching Australia web site
User avatar
Two Goth Geeks
50 or more caches found
50 or more caches found
Posts: 281
Joined: 05 April 03 7:02 pm
Twitter: TwoGothGeeks
Location: Sydney, Australia
Contact:

Post by Two Goth Geeks » 07 April 03 9:31 pm

I will test it on my other phpBB2 forums.

User avatar
Two Goth Geeks
50 or more caches found
50 or more caches found
Posts: 281
Joined: 05 April 03 7:02 pm
Twitter: TwoGothGeeks
Location: Sydney, Australia
Contact:

Post by Two Goth Geeks » 07 April 03 9:45 pm

Okay, got it.
It's a part of phpBB2.
The data doesn't have < br /> in the database, but when phpBB2 displays data to the screen, it always puts the < br /> after every line so that it shows properly when you view the forum posts.
Unfortunately, unless there is some way to tag the post as "HTML ONLY", it's a bit difficult to know whether to add the line breaks or not.
It'd be one for the ideo's to work out.

User avatar
ideology
Posts: 2763
Joined: 28 March 03 4:01 pm
Location: Sydney
Contact:

filxed (hopefully)

Post by ideology » 08 April 03 8:55 am

yes, it's in the code for viewing forum posts. it could be argued that it's a feature to allow you to sprinkle HTML tags within your post, but we think it's a bug!

after a bit of poking around, we've added a fix which appears to work

the drawback is that if you uncheck "Disable HTML in this post" (sorry about the double negative) you'll have to code in pure HTML, ie add your own <br> for newlines. please let us know if you see any other irregularities

red dwarf, if you have the same problem on your board, our modification was in viewtopic.php line 1131. we added the the if-statement in front of the string replacement:

Code: Select all

if (!($board_config['allow_html'] and $postrow[$i]['enable_html']))
    $message = str_replace("n", "n<br />n", $message);
thanks for bringing it up, leek. those HTML imports are much easier to read

leek
250 or more caches found
250 or more caches found
Posts: 573
Joined: 28 March 03 8:07 pm
Location: Lane Cove,NSW
Contact:

HTML Mod

Post by leek » 08 April 03 10:34 am

Hi Ideology,
Can you apply the same mod to the script that allows you to preview your message before submitting it as this still displays the blank lines...
Cheers,
Leek

User avatar
Two Goth Geeks
50 or more caches found
50 or more caches found
Posts: 281
Joined: 05 April 03 7:02 pm
Twitter: TwoGothGeeks
Location: Sydney, Australia
Contact:

Post by Two Goth Geeks » 08 April 03 11:02 pm

Thanks, id!
I don't generally allow HTML on my boards, so I don't have the problem. For those boards, there is no need for HTML.

PS: I reckon these boards are so much nicer than the ezboards. One of my phpbb2 boards I run was set up to get a bunch of people off ezboards. phpBB2 is so much nicer and easier to use IMO.

User avatar
ideology
Posts: 2763
Joined: 28 March 03 4:01 pm
Location: Sydney
Contact:

Post by ideology » 09 April 03 8:02 am

oops, wouldn't you think that the preview used the same code?

we've updated posting.php line 708 to read

Code: Select all

  if (!$html_on)
      $preview_message = str_replace("n", '<br />', $preview_message);
it seems to work. please let us know if you see any problems.

Post Reply